Add a plugin for IPAddress (ipv4) #692
Conversation
perryzjc
force-pushed
the
feature-plugin-ip
branch
from
2d5ffb6 to
1c89535
Compare
|
FYI @KevinHock - thoughts? |
|
Hi @perryzjc, thank you for opening this PR. I noticed our PR checks did not run, so I'll have to figure what happened there first. Rest assured I'll get to this as soon as possible. |
|
@perryzjc hi again 😄 could you please merge master into your branch? |
@lorenzodb1 hi again, I've merged the latest updates from the master branch into my feature branch as requested. Please let me know if there's anything else needed for this pull request. Thanks! |
|
@perryzjc looks like there's some pre-commit checks failing, please take a look |
@lorenzodb1 Thanks for letting me know. I've resolved the issues and all checks are now passing in the workflow. |
perryzjc
force-pushed
the
feature-plugin-ip
branch
from
ac853b9 to
62c0dd5
Compare
|
Hey @lorenzodb1 @jpdakran - just wanted to follow-up here. It would be great to have these plugins part of the main codebase when you get a chance! Great job @perryzjc. |
|
Hi @riverma, I have a bit of a backlog, but I promise you I'll get to this (and other great PRs) as soon as possible. |
Thank you @lorenzodb1 for your support! |
There was a problem hiding this comment.
@perryzjc thank you for your contribution! These changes will be included in the next release coming up at the end of this week 😄
This PR introduces a new feature in the form of an IP address detector. This detector scans for public IP addresses (IPv4) and ignores certain non-public IPv4 addresses. The ignored addresses include 127.x.x.x, 10.x.x.x, 172.16-31.x.x and 192.168.x.x.
Currently, there is no specific functionality in our system that allows for the detection of any IP addresses.
With this feature change, the system can now detect public IPv4 addresses. It uses a regex-based detector to identify valid public IPv4 addresses and ignore certain non-public ones.
This PR does not introduce a breaking change. The new detector class IPAddressDetector is a standalone addition and does not alter or interfere with the existing code base.
In addition to the implementation of the IP Address Detector, this PR also includes comprehensive tests to ensure the correct functionality of the detector. It tests the detector against valid public and non-public IPv4 addresses, as well as invalid IP addresses
The reference for the definition of public and non-public IPv4 addresses can be found in the following links:
IPv4 Address Space
Private Network - Wikipedia
The code documentation has been updated to reflect these changes. The new feature is expected to enhance the system's capabilities in handling IP address-related data.